forked from ayende/rhino-security
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix createchildusergroup #11
Open
joramwangi
wants to merge
8
commits into
hibernating-rhinos:master
Choose a base branch
from
joramwangi:fix-createchildusergroup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix createchildusergroup #11
joramwangi
wants to merge
8
commits into
hibernating-rhinos:master
from
joramwangi:fix-createchildusergroup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en and thus parent.AllChildren returned direct children and not all children irrespective of nesting
Can you resolve the conflicts first please? I'm not in a good position to resolve them as I have not worked with this code base in a while. Thanks for the work though! I'll be happy to merge when you resolve the conflicts. |
…r' into fix-createchildusergroup Conflicts: Rhino.Security.Windsor/RhinoSecurityInstaller.cs
…e same count even when different
All tests pass except for RemovingUserFromGroupInvalidatesSecondLevelCache() |
whyer
added a commit
to whyer/rhino-security
that referenced
this pull request
Jan 8, 2020
This implements another way of adding the security enhancements to a Linq query. This is a cherry-pick of PR hibernating-rhinos#11 on ayende/rhino-security on GitHub (ayende#11) After some evaluation I went for Mark Junkers implementation because it did not depend on LinkKit. Even though I think my implementation is cleaner and much easier to understand. I think that a library of this kind should be really easy to use in an solution and to minimize external dependencies is a worth alot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the whitespace. main change was
Initially only direct children were being added and thus if in a nested scenario group.AllChildren will only return direct children unlike group.AllParents